TS: Don't extract "redirecting" SourceFiles#1247
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for ODASA-7908.
Under rare circumstances the AST we get from the TypeScript API is a "redirecting" SourceFile, which can't be extracted like other SourceFiles.
I tried finding out under what circumstances this happens, but based on an this assertion in the TypeScript compiler it seems to be unintended behavior. So I've just worked around it the best we can.
I've confirmed that it works for the original project, but I haven't been able to reproduce it anywhere else. So unfortunately no regression test and no TypeScript bug report as I have no idea how it reproduce it in a small test case.